Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jvm-packages] Fixed a signature of XGBoostModel.predict #2476

Merged
merged 1 commit into from
Jul 3, 2017

Conversation

superbobry
Copy link
Contributor

Prior to this commit XGBoostModel.predict produced an RDD with
an array of predictions for each partition, effectively changing
the shape wrt the input RDD. A more natural contract for prediction
API is that given an RDD it returns a new RDD with the same number
of elements. This allows the users to easily match inputs with
predictions.

This commit removes one layer of nesting in XGBoostModel.predict output.
Even though the change is clearly non-backward compatible, I still
think it is well justified. See discussion in 06bd5dc for motivation.

@superbobry superbobry changed the title Fixed a signature of XGBoostModel.predict [jvm-packages] Fixed a signature of XGBoostModel.predict Jul 1, 2017
@superbobry superbobry force-pushed the better-predict branch 2 times, most recently from bea8491 to a329ebf Compare July 1, 2017 18:00
Prior to this commit XGBoostModel.predict produced an RDD with
an array of predictions for each partition, effectively changing
the shape wrt the input RDD. A more natural contract for prediction
API is that given an RDD it returns a new RDD with the same number
of elements. This allows the users to easily match inputs with
predictions.

This commit removes one layer of nesting in XGBoostModel.predict output.
Even though the change is clearly non-backward compatible, I still
think it is well justified. See discussion in 06bd5dc for motivation.
@CodingCat
Copy link
Member

merged, thx

@CodingCat CodingCat merged commit 8ceeb32 into dmlc:master Jul 3, 2017
@superbobry superbobry deleted the better-predict branch July 19, 2017 09:59
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants