Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: rework node resolution #2115

Merged
merged 1 commit into from
Nov 14, 2023

Commits on Nov 14, 2023

  1. build: rework node resolution

    This patch reworks and updates the node resolution logic for selecting a
    node from a builder.
    
    The new implementation reworks the logic to make use of containerd's
    platforms.Matcher interface instead of manually associated strings, and
    additionally provides a few behavioural changes over the original
    implementation, namely platforms can be matched with non-strict
    semantics. e.g. i386 builds can be scheduled on an amd64 node, arm/v6
    builds can be scheduled on an arm/v7 node.
    
    We also add a new collection of tests for tracking regressions and
    making the intended behaviour clearer.
    
    Signed-off-by: Justin Chadwell <me@jedevc.com>
    jedevc authored and crazy-max committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    616fb3e View commit details
    Browse the repository at this point in the history