Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] feat: build Fedora 41 RPM packages (carry #1055) #1058

Merged
merged 2 commits into from
Sep 4, 2024

Commits on Sep 4, 2024

  1. feat: build Fedora 41 RPM packages

    Signed-off-by: Robert Sturla <robertsturla@outlook.com>
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    p5 authored and thaJeztah committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    36c9cf2 View commit details
    Browse the repository at this point in the history
  2. rpm: install binutils-gold as a precaution for arm64 builds

    This is the equivalent of docker/containerd-packaging#390
    for containerd packages, but unlike for containerd packages, we currently do
    not run into this issue when building docker-ce packages. We're installing
    this as a precaution, but perhaps it's not needed.
    
    go1.21 and up have a patch that enforces the use of ld.gold to work around
    a bug in GNU binutils. See;
    
    - golang/go#22040.
    - golang/go@cd77738
    
    Fedora 41 and up has a fixed version of binutils, and no longer requires that
    patch, but may fail without ld.gold installed;
    
        /usr/bin/gcc -Wl,-z,now -Wl,-z,nocopyreloc -fuse-ld=gold -o $WORK/b001/exe/a.out -rdynamic /tmp/go-link-1738353519/go.o /tmp/go-link-1738353519/000000.o /tmp/go-link-1738353519/000001.o /tmp/go-link-1738353519/000002.o /tmp/go-link-1738353519/000003.o /tmp/go-link-1738353519/000004.o /tmp/go-link-1738353519/000005.o /tmp/go-link-1738353519/000006.o /tmp/go-link-1738353519/000007.o /tmp/go-link-1738353519/000008.o /tmp/go-link-1738353519/000009.o /tmp/go-link-1738353519/000010.o /tmp/go-link-1738353519/000011.o /tmp/go-link-1738353519/000012.o /tmp/go-link-1738353519/000013.o /tmp/go-link-1738353519/000014.o /tmp/go-link-1738353519/000015.o /tmp/go-link-1738353519/000016.o /tmp/go-link-1738353519/000017.o /tmp/go-link-1738353519/000018.o /tmp/go-link-1738353519/000019.o /tmp/go-link-1738353519/000020.o /tmp/go-link-1738353519/000021.o /tmp/go-link-1738353519/000022.o /tmp/go-link-1738353519/000023.o /tmp/go-link-1738353519/000024.o -O2 -g -lresolv -O2 -g -lpthread -O2 -g -ldl -O2 -g
        collect2: fatal error: cannot find 'ld'
    
    Fedora's build of Go carries a patch for that, but it's not (yet) in upstream;
    - https://src.fedoraproject.org/rpms/golang/blob/a867bd88a656c1d6e91e7b18bab696dc3fcf1e77/f/0006-Default-to-ld.bfd-on-ARM64.patch
    - https://src.fedoraproject.org/rpms/golang/c/a867bd88a656c1d6e91e7b18bab696dc3fcf1e77?branch=rawhide
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    563068b View commit details
    Browse the repository at this point in the history