Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): add a hint about multi-arch builds #359

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

favonia
Copy link
Contributor

@favonia favonia commented Nov 30, 2023

No description provided.

Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@favonia
Copy link
Contributor Author

favonia commented Nov 30, 2023

@dvdksn oops I didn't notice your approval and added more words. I hope it's okay.

@dvdksn
Copy link
Contributor

dvdksn commented Nov 30, 2023

@favonia addition looks good too :-) Please squash the commits

Document probably the most common usage of
`DOCKER_METADATA_ANNOTATIONS_LEVELS`: multi-arch builds.

Signed-off-by: favonia <favonia@gmail.com>
@favonia
Copy link
Contributor Author

favonia commented Nov 30, 2023

Done! (PS: I'm excited about the new feature. 😀)

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

PTAL @dvdksn

@dvdksn dvdksn merged commit 26b4721 into docker:master Nov 30, 2023
29 checks passed
@favonia favonia deleted the document-annotations branch November 30, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants