Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DijitWrapper should not preserve DOM on Dijit destruction #6

Closed
kitsonk opened this issue Sep 19, 2017 · 0 comments
Closed

DijitWrapper should not preserve DOM on Dijit destruction #6

kitsonk opened this issue Sep 19, 2017 · 0 comments
Assignees
@kitsonk
Labels
beta3 bug
Milestone
2017.09

Comments

@kitsonk
Copy link
Member

kitsonk commented Sep 19, 2017

Bug

The DijitWrapper should not preserve DOM when destroying a Dijit instance. This is because when a DijitWrapper is destroyed by the widgeting system, it is only done when the DOM it is responsible is supposed to be removed from the document. Preserving the DOM causes phantom Dijit instances to render when there is some sort of conditional rendering in the direct parent.
@kitsonk kitsonk added this to the 2017.09 milestone Sep 19, 2017
@kitsonk kitsonk self-assigned this Sep 19, 2017
@kitsonk kitsonk mentioned this issue Sep 19, 2017
Merged
3 tasks
kitsonk added a commit that referenced this issue Sep 19, 2017
@kitsonk
Do not preserve DOM with DijitWrapper (#7)
2ac6df1 
Fixes #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kitsonk kitsonk

Labels
beta3 bug
Projects
None yet
Milestone
2017.09
Development

No branches or pull requests
1 participant
@kitsonk