Document ReduxInjector #14
Conversation
|
@maier49 the example on the PR is now slightly out of date, I'll comment on the diffs in the morning :) |
|
This is a real world usage that is up to date https://github.com/dojo/examples/blob/master/todo-mvc-tsx/src/main.ts |
maier49
force-pushed
the
document-redux-injector
branch
from
331ec02
to
50eb3f6
Compare
|
@agubler I updated the example, and also the wording, based on that example. Let me know if the updated wording needs any tweaks. |
README.md
Outdated
| *Coming Soon* | ||
| `ReduxInjector` can be used to bind a redux store and Dojo 2 widgets using the `registry`. | ||
|
|
||
| An injector can be defined in the registry, which is then registered with the `Router`, and provided to the `Projector` as one of its properties. This is demonstrated in the example below. |
There was a problem hiding this comment.
I don't understand this sentence, the Router doesn't have anything to do with the using the ReduxInjector...
README.md
Outdated
| const store = createStore(todoReducer, defaultState, global.__REDUX_DEVTOOLS_EXTENSION__ && global.__REDUX_DEVTOOLS_EXTENSION__()); | ||
| registry.defineInjector('application-state', new ReduxInjector(store)); | ||
|
|
||
| const config = [ |
There was a problem hiding this comment.
Can drop anything router related from the examples (might be confusing)
README.md
Outdated
| }; | ||
|
|
||
| const registry = new Registry(); | ||
| const store = createStore(todoReducer, defaultState, global.__REDUX_DEVTOOLS_EXTENSION__ && global.__REDUX_DEVTOOLS_EXTENSION__()); |
There was a problem hiding this comment.
might want to call out that this initialises the redux dev tools extension (and maybe a link to it?).
There was a problem hiding this comment.
do we need this in the readme?
There was a problem hiding this comment.
Nope probably not to be honest.
There was a problem hiding this comment.
I removed the redux dev tools extension from the example code and removed the explanation about it.
|
@agubler Updated again |
The following has been addressed in the PR:
Description:
Adds the redux injector documentation from the PR to the README
Resolves #9