Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export DoltSystemVariables var so that it can be used by doltgres #8306

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Export DoltSystemVariables var so that it can be used by doltgres #8306

merged 2 commits into from
Sep 4, 2024

Conversation

tbantle22
Copy link
Contributor

No description provided.

@coffeegoddd
Copy link
Contributor

@tbantle22 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
17e0a8c ok 5937457
version total_tests
17e0a8c 5937457
correctness_percentage
100.0

@tbantle22 tbantle22 mentioned this pull request Sep 3, 2024
Merged
@coffeegoddd
Copy link
Contributor

@tbantle22 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e35edee ok 5937457
version total_tests
e35edee 5937457
correctness_percentage
100.0

Hydrocharged
Hydrocharged approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tbantle22 tbantle22 merged commit bbeddb4 into main Sep 4, 2024
21 checks passed
@tbantle22 tbantle22 deleted the taylor/export-var branch September 4, 2024 14:22
@BrewTestBot BrewTestBot mentioned this pull request Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbantle22 @coffeegoddd @Hydrocharged