Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for schemas in various version control operations #8343

Merged
merged 26 commits into from
Sep 11, 2024

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Sep 11, 2024

This change adds support for schemas in dolt_add, dolt_merge, and dolt_status. Many places that had a string for a table name now have a doltdb.TableName.

Also fixes a newly discovered bug with creating a database:

  1. creating a DB with a collation left the working set dirty
  2. DBs created in a transaction couldn't be queried until starting a new tx

@coffeegoddd
Copy link
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
635952e ok 5937457
version total_tests
635952e 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
f97495a ok 5937457
version total_tests
f97495a 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
a9e1dd6 ok 5937457
version total_tests
a9e1dd6 5937457
correctness_percentage
100.0

@zachmu
Copy link
Member Author

zachmu commented Sep 11, 2024

dolthub/doltgresql#694

@coffeegoddd
Copy link
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
db831c5 ok 5937457
version total_tests
db831c5 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
9d6c7ae ok 5937457
version total_tests
9d6c7ae 5937457
correctness_percentage
100.0

Copy link
Contributor

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! No code comments

go/libraries/doltcore/merge/merge.go Outdated Show resolved Hide resolved
@Hydrocharged
Copy link
Contributor

Hydrocharged commented Sep 11, 2024

Integration workflow had a small bug that has since been fixed, so this failure can be ignored

@zachmu zachmu merged commit 01bd340 into main Sep 11, 2024
18 of 19 checks passed
@coffeegoddd
Copy link
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
0d463ca ok 5937457
version total_tests
0d463ca 5937457
correctness_percentage
100.0

Copy link

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.05 1.6
batching batch sql 10000 1 0.07 1.86
batching by line sql 10000 1 0.07 1.86
blob 1 blob 200000 1 0.88 3.9 3.61
blob 2 blobs 200000 1 0.86 4.53 4.43
blob no blob 200000 1 0.9 2.37 1.97
col type datetime 200000 1 0.82 3.04 2.78
col type varchar 200000 1 0.68 3.32 2.78
config width 2 cols 200000 1 0.77 2.53 1.96
config width 32 cols 200000 1 1.84 1.98 2.35
config width 8 cols 200000 1 0.97 2.37 1.92
pk type float 200000 1 0.83 2.8 1.86
pk type int 200000 1 0.8 2.68 1.91
pk type varchar 200000 1 1.49 1.72 1.39
row count 1.6mm 1600000 1 5.57 2.95 2.28
row count 400k 400000 1 1.45 2.77 2.13
row count 800k 800000 1 2.87 2.83 2.18
secondary index four index 200000 1 3.56 1.37 1.05
secondary index no secondary 200000 1 0.86 2.47 2.07
secondary index one index 200000 1 1.1 2.45 2.01
secondary index two index 200000 1 1.95 1.76 1.4
sorting shuffled 1mm 1000000 0 4.73 2.94 2.32
sorting sorted 1mm 1000000 1 4.9 2.86 2.24

Copy link

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.25
dolt_blame_commit_filter system table 3.38
dolt_commit_ancestors_commit_filter system table 0.85
dolt_commits_commit_filter system table 1.05
dolt_diff_log_join_from_commit system table 2.03
dolt_diff_log_join_to_commit system table 2
dolt_diff_table_from_commit_filter system table 1.15
dolt_diff_table_to_commit_filter system table 1.17
dolt_diffs_commit_filter system table 0.93
dolt_history_commit_filter system table 1.38
dolt_log_commit_filter system table 1.05

Copy link

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 0.72
adds_updates_deletes 60000 60000 60000 3.81
deletes_only 0 60000 0 1.86
updates_only 0 0 60000 2.46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants