Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved enginetests to their own testing CI workflow, don't use -race #717

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Sep 18, 2024

This works around the problem described here:

#718

… difficult to debug (has something to do with running multiple Dolt servers at the same time). For now, put them in their own workflow with no race testing.
Copy link
Contributor

github-actions bot commented Sep 18, 2024

Main PR
Total 42090 42090
Successful 10817 10824
Failures 31273 31266
Partial Successes1 4702 4715
Main PR
Successful 25.6997% 25.7163%
Failures 74.3003% 74.2837%

Regressions:

arrays

QUERY:          select array_to_string(array[1,2,3,4,NULL,6], ',');
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

boolean

QUERY:          SELECT bool 't' AS true;
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          SELECT BOOLTBL1.*
   FROM BOOLTBL1
   WHERE f1 = bool 'true';
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          SELECT istrue OR isfalse OR isnul FROM booltbl4;
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

case

QUERY:          SELECT CASE WHEN 1=0 THEN 1/0 WHEN 1=1 THEN 1 ELSE 2/0 END;
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

char

QUERY:          SELECT 'a'::"char";
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          SELECT 'a'::text::"char";
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

collate.icu.utf8

QUERY:          SELECT * FROM collate_test1 WHERE b ~ '^abc$';
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          SELECT * FROM test4 WHERE b = 'cote';
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

constraints

QUERY:          SELECT 'one' AS one, nextval('insert_seq');
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

create_type

QUERY:          select format_type('bpchar'::regtype, null);
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          select format_type('bpchar'::regtype, -1);
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

date

QUERY:          SELECT EXTRACT(MILLENNIUM    FROM DATE '2020-08-11');
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

expressions

QUERY:          SELECT current_catalog = current_database();
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

float4

QUERY:          SELECT 'Infinity'::float4 / 'Infinity'::float4;
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

float8

QUERY:          SELECT 'nan'::float8 / 'nan'::float8;
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          SELECT power(float8 'NaN', float8 '0');
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          SELECT power(float8 '-inf', float8 '0');
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          SELECT power(float8 '1', float8 '-inf');
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          SELECT power(float8 '-1', float8 '-inf');
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          SELECT power(float8 '-0.1', float8 'inf');
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          SELECT power(float8 '-1.1', float8 '-inf');
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          SELECT cosh(float8 'nan');
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          SELECT tanh(float8 '-infinity');
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

int2

QUERY:          SELECT i.* FROM INT2_TBL i WHERE (i.f1 % int2 '2') = int2 '1';
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

int4

QUERY:          SELECT int4 '1000' < int4 '999' AS false;
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          SELECT ((-1::int4<<31)+1)::text;
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

int8

QUERY:          SELECT (-9223372036854775808)::int8 % (-1)::int4;
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

interval

QUERY:          SELECT interval '1' year;
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          SELECT interval '1 2:03:04' day to second;
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          SELECT interval '1 -2:03' minute to second;
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          SELECT EXTRACT(DECADE FROM INTERVAL '100 y');
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          SELECT EXTRACT(CENTURY FROM INTERVAL '100 y');
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

join

QUERY:          select nt3.id
from nt3 as nt3
  left join
    (select nt2.*, (nt2.b1 and ss1.a3) AS b3
     from nt2 as nt2
       left join
         (select nt1.*, (nt1.id is not null) as a3 from nt1) as ss1
         on ss1.id = nt2.nt1_id
    ) as ss2
    on ss2.id = nt3.nt2_id
where nt3.id = 1 and ss2.b3;
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          select * from
  (select 0 as z) as t1
  left join
  (select true as a) as t2
  on true,
  lateral (select true as b
           union all
           select a as b) as t3
where b;
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          select * from (select f1/2 as x from int4_tbl) ss1 join int4_tbl i4 on x = f1,
  lateral (select x) ss2(y);
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

json

QUERY:          select '[{"b": "c"}, {"b": "cc"}]'::json #> array['1','b'];
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

json_encoding

QUERY:          SELECT jsonb '{ "a":  "dollar \u0024 character" }' as correct_everywhere;
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

jsonb

QUERY:          SELECT '{}'::jsonb;
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          SELECT test_json -> 'field2' FROM test_jsonb WHERE json_type = 'object';
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          select '{"a": "c", "b": null}'::jsonb -> 'b';
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          select '12345'::jsonb::int4;
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          select '12345.05'::jsonb::float8;
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          select '12345.05'::jsonb::int8;
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

name

QUERY:          SELECT c.f1 FROM NAME_TBL c WHERE c.f1 = '1234567890ABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890ABCDEFGHIJKLMNOPQR';
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

numeric

QUERY:          select div (70.0,70) ;
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          select ln(5.80397490724e5);
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          select trim_scale(0.00);
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          select trim_scale(-1123.124718561280000000);
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

regproc

QUERY:          SELECT to_regtype('pg_catalog.int4');
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

strings

QUERY:          SELECT TRIM(LEADING FROM '  bunch o blanks  ') = 'bunch o blanks  ' AS "bunch o blanks  ";
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          SELECT TRIM(BOTH 'x' FROM 'xxxxxsome Xsxxxxx') = 'some Xs' AS "some Xs";
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          SELECT regexp_replace('A PostgreSQL function', 'a|e|i|o|u', 'X', 1, 3, 'i');
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          SELECT POSITION('5' IN '1234567890') = '5' AS "5";
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          SELECT 'hawkeye' LIKE 'H%' AS "false";
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          SELECT 'jack' LIKE '%____%' AS t;
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          SELECT text 'text' || ' and unknown' AS "Concat text to unknown type";
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)
QUERY:          SELECT replace('yabadoo', 'bad', '') AS "yaoo";
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

text

QUERY:          select 'four: ' || 2+2;
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

transactions

QUERY:          SELECT * FROM trans_barbaz;
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

xid

QUERY:          select 'asdf'::xid;
RECEIVED ERROR: returned values differ (order was ignored due to missing ORDER BY)

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@zachmu zachmu merged commit 8dcc798 into main Sep 18, 2024
13 checks passed
@zachmu zachmu deleted the zachmu/workflows branch September 18, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants