Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can only change dataset from bottom option, not top #1033

Closed
Sarronnn opened this issue Apr 12, 2023 · 4 comments
Closed

Can only change dataset from bottom option, not top #1033

Sarronnn opened this issue Apr 12, 2023 · 4 comments

Comments

@Sarronnn
Copy link
Collaborator

Screenshot 2023-04-11 at 11 38 28 PM

Screenshot 2023-04-11 at 11 39 24 PM

@kdahlquist
Copy link
Collaborator

This still has some problems on Beta 7.0.2

  • If I select the top and bottom datasets from the side panel, the changes are not reflected in the top menu. It does weird things
    • If I select the top dataset first from the side panel, then the right top dataset is reflected in the menu, but not the bottom dataset.
    • If I select the bottom dataset first from the side panel, then neither the top dataset or bottom dataset are checked off in the menu.
  • Strange things happen when selecting datasets from the top menu.

@dondi
Copy link
Owner

dondi commented Sep 19, 2023

Fundamentally, the core issue is that the selected dataset should be centralized to an internal state value: whenever any control or UI element changes this value, that change should lead to the same code regardless of the source. Doing so will ensure that the internal behavior is always the same independent of whether the change was made on the sidebar or the menu

ntran18 added a commit that referenced this issue Sep 24, 2023
ntran18 added a commit that referenced this issue Oct 9, 2023
@dondi
Copy link
Owner

dondi commented Oct 10, 2023

@ntran18 as a PR for this and that is what the “review requested” tag indicates; however she documents that a subsequent bug appears which seems to be more related to the dataset than the UI

@ntran18 will extract this as a separate issue, likely to be addressed after this one is merged into beta

@dondi dondi mentioned this issue Oct 10, 2023
@dondi
Copy link
Owner

dondi commented Oct 10, 2023

The UI-level bug appears to be fixed but the fix is disrupted by a new issue that appears to occur at the data level, especially for expression data sets that come from the database and are not read from the network directly. Will consider this item as closed but @ntran18 will write up and investigate the missing data portion as a new issue

The new issue can reference this one in case we need to review how it was discovered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants