Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When node coloring data doesn't exist in a spreadsheet, other features break #753

Closed
mihirsamdarshi opened this issue May 24, 2019 · 3 comments
Closed

When node coloring data doesn't exist in a spreadsheet, other features break #753

mihirsamdarshi opened this issue May 24, 2019 · 3 comments
Assignees
@mihirsamdarshi
Labels
bug functionality priority 0 review requested

Comments

@mihirsamdarshi
Copy link
Collaborator

Most notably, grid layout doesn't work because the drawGraph function looks for expression data to parse
@mihirsamdarshi mihirsamdarshi self-assigned this May 24, 2019
@mihirsamdarshi
Copy link
Collaborator Author

Just fixed, will push to a new PR

mihirsamdarshi added a commit that referenced this issue May 24, 2019
@mihirsamdarshi
fixed no Expression Data bug documented in issue #753
d8af752
@mihirsamdarshi mihirsamdarshi mentioned this issue May 24, 2019
Merged
mihirsamdarshi added a commit that referenced this issue May 24, 2019
@mihirsamdarshi
Merge pull request #754 from dondi/mihirsamdarshi
21c4118 
fixed no Expression Data bug documented in issue #753
@mihirsamdarshi mihirsamdarshi mentioned this issue May 28, 2019
Merged
@mihirsamdarshi
Copy link
Collaborator Author

this one should be reviewed and closed soon

@kdahlquist
Copy link
Collaborator

I made a simple 3 node network with just a "network" sheet and this seemed to be OK. I tried going back and forth between grid layout and force graph layout. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mihirsamdarshi mihirsamdarshi

Labels
bug functionality priority 0 review requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mihirsamdarshi @kdahlquist