Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed hard-coded database information and replaced them with database calls #1004

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Removed hard-coded database information and replaced them with database calls #1004

merged 1 commit into from
Dec 5, 2022

Conversation

Onariaginosa
Copy link
Collaborator

@Onariaginosa Onariaginosa mentioned this pull request Dec 5, 2022
Closed
dondi
dondi approved these changes Dec 5, 2022
View reviewed changes
Copy link
Owner

@dondi dondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; the hardcode removal is notable and is worth a version bump—will do that after merging

Similar style notes here as in #996 and in similar places also, so I didn’t leave redundant notes here anymore. Going through the #996 comments as stated in #1002 should still suffice

@dondi dondi merged commit d0109ea into beta Dec 5, 2022
@dondi dondi mentioned this pull request Dec 5, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dondi dondi dondi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Onariaginosa @dondi