#1106 Writing Scripts for Updating Database and Refactor Code #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate network gene, and update protein gene, making load_genes and update_genes to be private
….py. Adding all populating data to database in loader.py. Need to work on Readme file to update the command in the next commit, and fixing update scripts
…pdate, can create a union missing_gene and update_gene files. The code for loader_update will be in later commit.
…s, updated genes, misisng protein, updated proteins for both network and protein-protein interactions table
…ng instructions on how to update database
… of using union genes. The code for union genes can just leave it there for now
dondi
reviewed
Apr 23, 2024
There was a problem hiding this comment.
Generally looks good, with one historical note and I think we have an opportunity to address it: when we first started populating our database, we had only one network type (GRN), so many names in this code pertain to just “network.” But now that we also support PPIs, the proper naming scheme is no longer “network” vs. “PPI” but “GRN” vs. “PPI.” So please scan for any generic “network” names and adjust to indicate “GRN” instead. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loader.pyto load all data into expression, network, and protein-protein interactions databaseloader-update.pyto load all updates into network and protein-protein interactions database