Igreen1 #880
Merged
Igreen1 #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increased boundary margin by a few pixels to remove the appearance that the node (gene) was going over the rightmost edge.
Instead of increasing boundary, better calculation for right boundary
This will push the graph edges away from the viewport edge. In other words, the links between nodes will curve inwards if the node is sufficiently near the constraints of the viewport
Made weights of self-referential edges not able to move past viewport when locked
It removes a magic number and replaces it with the right variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #700 and fixes #444 and makes two minor corrections in the draw self-referential edge function
Nodes go slightly over edge when "Restrict Graph to Viewport" and "Fit to Window" is selected #700 was fixed by changing the calculation of RightBoundary to include an offset, which is a variable declared to be 5.
Weights should not be drawn outside the bounding box when the bounding box/viewport is fixed #444 was fixed with two changes. For self-referential edges, the textbox with the weight was bounded within the viewport. For all other edges, the edge path calculation was tweaked such that edges always curve inwards when near the edge (added an offset to the points on the edge line)
The two small corrections are