Igreen1 #896
Merged
Igreen1 #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libxmljs was added as a validator, then put into the current parser as a validator. However, I am having issues testing this
…these properties when the data does not contain them
Unfortunately, sif is very confusing so I wasn't able to do this there However, by keeping the optionals in the update-app, it doesn't metter So, now GraphML will work and SIF will work
Better fix for .sif files
…, not arrays to match data format Fixed tests to include new graphml and sif imports
The previous commit has a failed build because of this error
Minimize delta between commits :)
Changed arc offset back to 20, 30 was too much Changed self-referential offset calculations to use offset variable instead of magic numbers. Still magic numbers in calculation as offset is too small for x calculations, but I think this solution is still better
dondi
approved these changes
Nov 13, 2020
There was a problem hiding this comment.
In terms of addressing the issue, this looks good to me, although the number of times that meta/expression had to be manually added makes me wonder whether some consolidation is called for here (e.g., some kind of default “initialize empty network” function or some such.
Perhaps a refactor to do next.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #886 by finally fixing the tests that didn't allow the last PR to function properly. The fix adds an expression and a meta property to all import networks so later attempts to access these properties returns the expected undefined instead of an error.
Addresses issue #444 by increasing the margin of the self-referential edges
The fix for #541 was removed from my branch due to a sudden issue with the library. I suspect it is an issue with my local machine and hope to resolve it tonight (after my lab report)