Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test import of GRNmap input workbooks for two-column-formatted sheets #900

Merged
merged 2 commits into from
Dec 4, 2020

Conversation

Onariaginosa
Copy link
Collaborator

Added tests mentioned in issue #883

completed two column sheets and tests, non-standard sheet tests are a work in progress
Copy link
Owner

@dondi dondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, with some notes on blank lines in test.js.





Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don’t really need to space things out this much but nbd 😂





Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, if you really wanted to separate things this distinctly, maybe a new module file is called for? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants