Test import of GRNmap input workbooks for non-standard formatted worksheets #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…optimization parameters tester code. In the process of completing optimizations diagnostics tests
dondi
approved these changes
Jan 8, 2021
| return (column === 0) ? "Parameter" : "Value"; | ||
| } | ||
| } else { | ||
| // if (sh) |
There was a problem hiding this comment.
Is this unfinished or is else genuinely not needed?
| @@ -336,11 +421,11 @@ const parseTwoColumnSheet = (sheet) => { | |||
| } | |||
| } | |||
| if (sheet.data[row].length > 1) { | |||
| if (sheet.data[row][1] !== getSheetHeader(sheet.name, 1)) { | |||
| if (sheet.data[row][1] !== getSheetHeader(sheet.name, 1, row)) { | |||
There was a problem hiding this comment.
Interesting what’s happening here…we either need to talk about this or if I’ve forgotten, I’ll need to refresh my memory on this game plan. It looks like row has been added as a parameter to getSheetHeader, but getSheetHeader only does something if row === 0, and as far as I can tell, all invocations of getSheetHeader also have row === 0.
It looks like you are planning some additional work here, something for this semester?
dondi
added a commit
that referenced
this pull request
Jan 8, 2021
Integrating #902 from @Onariaginosa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed testing for Optimization Parameters and Optimization Diagnostics sheets, as mentioned in issue #884