Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #917 GRNsight should read and retain all network sheets #918

Merged
merged 4 commits into from
Mar 24, 2021

Conversation

Onariaginosa
Copy link
Collaborator

@Onariaginosa Onariaginosa commented Mar 17, 2021

Implements changes requested in issue #917

Changed warning intro to tell the user that the file may not export properly. ( #884 )

Pull Request Checklist

  • Travis C.I. build passes
  • All four Demos look as expected when loaded
  • Reload works as expected
  • Loading file with Error brings up error modal, and it looks as expected
  • Loading file with Warning brings up warnings modal
  • Import works for both SIF and GraphML
  • Graph can be exported to SIF and GraphML
  • Print works as expected
  • Restrict graph to viewport works as expected (check/uncheck)
  • Viewport Size Changing works as expected (small/medium/large/fit)
  • Toggle between Grid Layout and Force Graph Layout works as expected
  • Force Graph Parameter Sliders change the number above them and have an effect on the graph
  • Locking/Unlocking/Resetting/Undo Resetting the force graph parameters works as expected
  • Enabling and disabling node coloring works as expected
  • Node coloring options work as expected (selection top/bottom dataset, averaging values, changing max value)
  • Weighted graph loaded with the "default to black edges" option checked appears as expected
  • Hide/Show Weights works as expected (always/never/upon mouseover)
  • Edge Weight Normalization Factor can be changed (set/reset)
  • Gray Edge Threshold can be changed, slider changes the number and has an effect on the graph
  • Checking Show Gray Edges as Dashed works as expected (check/uncheck)
  • D-pad left/right/top/bottom/center works as expected
  • Zoom slider changes number and has effect on graph (viewport and menu)
  • Right click on a node opens gene page, page is populated with correct data

@igreen1 igreen1 self-requested a review March 17, 2021 23:25
@ahmad00m
Copy link
Collaborator

@ahmad00m has gone through the checklist and found no issues pertaining to any of the checkboxes.

Copy link
Owner

@dondi dondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The one thing I could think of (but this is beyond the PR) is whether there are repeated blocks of data in demo-workbooks.js that can be consolidated into subobjects/subvariables that can be copied where used. This may reduce potential duplicate edits

But, that is outside of this PR so LGTM either way!

@dondi dondi merged commit c773e24 into beta Mar 24, 2021
dondi added a commit that referenced this pull request Mar 24, 2021
This includes PR #918 from @Onariaginosa, fixing #917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants