Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] FSharp support #149

Closed
bradphelan opened this issue Sep 29, 2017 · 3 comments
Closed

[Enhance] FSharp support #149

bradphelan opened this issue Sep 29, 2017 · 3 comments

Comments

@bradphelan
Copy link

When added to an fsharp project there is an error about CodeDom missing. Not surprising but is there a chance support can be added?

@bradphelan
Copy link
Author

Actually the error is weird. I have some fsharp projects but Nerdbank.Gitversioning is not installed. I get

676 Warning(s)
0 Error(s)

Time Elapsed 00:03:11.37
.\build.bat : Building WeinCad.Net.sln failed with exitcode 1.
At line:1 char:1

  • .\build.bat 2>&1 | Tee-Object -FilePath build.log
  •   + CategoryInfo          : NotSpecified: (Building WeinCa...ith exitcode 1.:String) [], RemoteException
      + FullyQualifiedErrorId : NativeCommandError
    
    

: C:\Users\phelan\workspace\WeinCAD.NET\packages\Nerdbank.GitVersioning.2.0.41\build\Nerdbank.GitVersioning.targets(135,5): CodeDomProvider not available for language: F#. No version info will be embedded i
nto assembly.
Stopped due to error
C:\Users\phelan\workspace\WeinCAD.NET [feature/general-z-axis-corrections ↑ +56 ~84 -0 !]> gvim .\build.log

but it doesn't say which assembly and there is nothing else in the log

@AArnott
Copy link
Collaborator

AArnott commented Sep 29, 2017

NB.GV already has some support for manually generating source code when CodeDom is absent, since this is required for dotnet build. So yes, I think F# support could be added.
As I'm not an F# syntax expert, I'd prefer to add this by way of accepting someone else's PR.

@bradphelan
Copy link
Author

Ahhhh. Ignore my previous post about the error still being there even though the FSharp projects didn't include the nuget package. That was some weird stuff that hasn't happened again. But I created a pull request anyway to at least put the name of the assembly in the error messages. :)

I might add stuff for FSharp if it turns out I need them.

AArnott added a commit that referenced this issue Nov 24, 2018
Fix for issue #149 - Adding F# support for AssemblyInfo generation
@AArnott AArnott closed this as completed Nov 24, 2018
AArnott added a commit that referenced this issue Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants