API diff between .NET 9 Preview 4 and .NET 9 Preview 5 #9352
Conversation
...s/9.0/preview/preview5/api-diff/Microsoft.AspNetCore.App/9.0-preview5_System.IO.Pipelines.md
Outdated
Show resolved
Hide resolved
...0/preview/preview5/api-diff/Microsoft.NETCore.App/9.0-preview5_System.Diagnostics.Metrics.md
Outdated
Show resolved
Hide resolved
|
I left a comment regarding |
|
@mairaw is there a known issue with the CI validation in this repo? The "Checking for ability to merge automatically" message is stuck. |
| # System.IO.Pipelines | ||
|
|
||
| ``` diff | ||
| +namespace System.IO.Pipelines { |
There was a problem hiding this comment.
Do we need to do anything special to indicate that these are existing APIs that have been part of the Microsoft.AspNetCore.App shared runtime since its inception and published as a NuGet even longer?
The only thing new about it is its inclusion in the Microsoft.NETCore.App shared runtime as well. The System.Text.Json changes look good though. @BrennanConroy
There was a problem hiding this comment.
Just let me know and I can remove them. Is it the case for all the APIs in this namespace?
There was a problem hiding this comment.
I can address this in a separate PR. I'll merge this as is.
Repo area owners:
Libraries area owners:
Known api-diff tool issues:
If yo usee any of these, please provide a GitHub suggestion in this PR to correct it:
{or{}arcade#10981([AsmDiff] For attributes, move the +/- diff symbol to the attribute instead of the affected API arcade#13814)protected internalvisibility should stop showing. AsmDiff: Do not show APIs withprotected internalvisibility arcade#14579