Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections to the lists of Linux package dependencies #18989

Merged
merged 2 commits into from
Jun 29, 2020

Conversation

mthalman
Copy link
Member

The current set of Linux package dependencies across the supported set of distros have some inaccuracies. There are cases of packages that aren't listed, packages that shouldn't be listed, and updates to package versions that are needed.

cc @Thraka, @dagood, @MichaelSimons

@dagood
Copy link
Member

dagood commented Jun 17, 2020

+cc @NikolaMilosavljevic

@Thraka
Copy link
Contributor

Thraka commented Jun 17, 2020

I was just having a conversation about this with @leecow

EDIT: I just need someone to validate the values are correct.

@@ -122,7 +122,7 @@ sudo apt-get update; \

## Dependencies

[!INCLUDE [linux-install-dependencies](includes/linux-install-dependencies.md)]
[!INCLUDE [linux-rpm-install-dependencies](includes/linux-rpm-install-dependencies.md)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency list for Debian is not the same as what is listed in the rpm document.

Debian 10: libicu63, libssl1.1
Debian 9: libicu57, libssl1.1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Member

@leecow leecow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments for changes and a question.

Copy link
Member

@leecow leecow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants