Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #17376 - Compiler hangs when compiling inline recursive invocation #17376 #17394

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Fixes #17376 - Compiler hangs when compiling inline recursive invocation #17376 #17394

merged 2 commits into from
Jul 9, 2024

Conversation

KevinRansom
Copy link
Member

Fixes: #17376

Adds regression

@KevinRansom KevinRansom requested a review from a team as a code owner July 9, 2024 00:16
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Caution

Repository is on lockdown for maintenance, all merges are on hold.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.100.md

@KevinRansom KevinRansom closed this Jul 9, 2024
@KevinRansom KevinRansom reopened this Jul 9, 2024
slyshykO
slyshykO reviewed Jul 9, 2024
View reviewed changes
docs/release-notes/.FSharp.Compiler.Service/9.0.100.md Outdated
@@ -1,4 +1,5 @@
### Fixed
* Compiler hangs wne compiling inline recursive invocation ([Issue #17376](https://github.com/dotnet/fsharp/issues/17376), [PR #17394](https://github.com/dotnet/fsharp/pull/17394))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo wne
should be "when" ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@T-Gro
Copy link
Member

T-Gro commented Jul 9, 2024

Could you also add the code snippet from the issue as a test?

@KevinRansom
Copy link
Member Author

Could you also add the code snippet from the issue as a test?

Could you also add the code snippet from the issue as a test?

We have virtually identical code here: https://github.com/dotnet/fsharp/blob/main/tests/FSharp.Compiler.ComponentTests/Conformance/InferenceProcedures/RecursiveSafetyAnalysis/E_RecursiveInline.fs

@psfinaki psfinaki changed the title Fixes #17376 - Compiler hangs wne compiling inline recursive invocation #17376 Fixes #17376 - Compiler hangs when compiling inline recursive invocation #17376 Jul 9, 2024
@vzarytovskii vzarytovskii merged commit 2234432 into dotnet:main Jul 9, 2024
29 of 30 checks passed
This was referenced Jul 25, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slyshykO slyshykO slyshykO left review comments

@psfinaki psfinaki psfinaki approved these changes

@T-Gro T-Gro T-Gro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler hangs wne compiling inline recursive invocation
5 participants
@KevinRansom @T-Gro @slyshykO @psfinaki @vzarytovskii