Fix setting ProjectMetadataElement.Name #10673
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfederm
force-pushed
the
fix-metadata-name-setter
branch
from
685cba3
to
5d01701
Compare
JanKrivanek
approved these changes
Sep 20, 2024
| /// <param name="oldName">The old name for the child element</param> | ||
| internal void UpdateElementName(ProjectElement child, string oldName) | ||
| { | ||
| ErrorUtilities.VerifyThrow(Link == null, "External project"); |
There was a problem hiding this comment.
Please add an error message that would be understandable to anyone reviewing log of crashing msbuild.
(This is inspired by still painful memory of troubleshooting sudden msbuild crashes with error message being "must be valid")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10671
Currently the
ProjectMetadataElement.Namesetter updates the XmlNode forProjectMetadataElement, but when the metadata is expressed as an attribute it does not update the attribute on the parent node.This change does the bookeeping for the parent node.
One interesting tidbit is how even when expressed as an attribute,
ProjectMetadataElementstill uses an (unparented)XmlElementWithLocationto represent it.