Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCS1268 - Simplify Numeric Comparison #1405

Merged
merged 7 commits into from
Feb 26, 2024

Conversation

jakubreznak
Copy link
Contributor

fixes #1394

@josefpihrt
Copy link
Collaborator

Is this PR ready for review? If so, can you request a review?

@jakubreznak
Copy link
Contributor Author

jakubreznak commented Feb 20, 2024

Yes, the PR is ready for review. Could you please review my code? Thanks

(I wanted to add you to reviewers, but i cannot.)

@josefpihrt
Copy link
Collaborator

I see, I didn't know you cannot request a review.

So, just to be clear, what do you see in the UI?

I see this:

image

@jakubreznak
Copy link
Contributor Author

image

I see this.

@josefpihrt
Copy link
Collaborator

Thanks for the screenshot. It's probably because the repo is part of dotnet organization.

@josefpihrt josefpihrt self-requested a review February 20, 2024 17:42
@jakubreznak
Copy link
Contributor Author

Thank you for the code review and your suggestions. I have implemented the changes you suggested.

@josefpihrt josefpihrt merged commit 823d74b into dotnet:main Feb 26, 2024
17 checks passed
@josefpihrt
Copy link
Collaborator

@jakubreznak Nice PR, thanks!

@BenjaminBrienen
Copy link
Contributor

@josefpihrt
Copy link
Collaborator

@BenjaminBrienen Changelog contains incorrect information that this analyzer is part of 4.11.0 but it haven't been released yet. Changelog will be fixed as a part of next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify numeric comparison
3 participants