Skip to content

Commit

Permalink
Fix DAC stack overflow in GetUsefulGlobals API (#105962)
Browse files Browse the repository at this point in the history
Co-authored-by: Mike McLaughlin <mikem@microsoft.com>
  • Loading branch information
github-actions[bot] and mikem8361 committed Aug 5, 2024
1 parent 61126f5 commit 0d79e6d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/coreclr/debug/daccess/request.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2408,7 +2408,7 @@ ClrDataAccess::GetMethodTableForEEClass(CLRDATA_ADDRESS eeClassReallyCanonMT, CL
}
else
{
hr = GetMethodTableForEEClassImpl (eeClassReallyCanonMT, value);
hr = GetMethodTableForEEClassImpl(eeClassReallyCanonMT, value);
}
SOSDacLeave();
return hr;
Expand Down Expand Up @@ -3535,7 +3535,7 @@ ClrDataAccess::GetUsefulGlobals(struct DacpUsefulGlobalsData* globalsData)
hr = m_cdacSos->GetUsefulGlobals(globalsData);
if (FAILED(hr))
{
hr = GetUsefulGlobals(globalsData);
hr = GetUsefulGlobalsImpl(globalsData);
}
#ifdef _DEBUG
else
Expand All @@ -3554,7 +3554,7 @@ ClrDataAccess::GetUsefulGlobals(struct DacpUsefulGlobalsData* globalsData)
}
else
{
hr = GetUsefulGlobals(globalsData);;
hr = GetUsefulGlobalsImpl(globalsData);;
}

SOSDacLeave();
Expand Down

0 comments on commit 0d79e6d

Please sign in to comment.