Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging] Use clang --version to get Apple toolset version #100199

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 24, 2024

Backport of #100190 to release/8.0-staging

/cc @jkotas

Customer Impact

  • Customer reported
  • Found internally

The xcodebuild tool used to identify the Apple native toolset version is only available with full Xcode installation. It is not available in command line only installation of the Apple toolset used by some customers.

The fix is to use clang to identify the Apple native toolset version instead.

Regression

  • Yes
  • No

Regression introduced by earlier .NET 8 servicing fix (#97856) that added workaround for an issue with latest Apple native toolset.

Testing

The fix was independently validated #100190 (review)

Risk

Low

Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we can take this as a tell mode fix.

@jkotas jkotas added the Servicing-approved Approved for servicing release label Apr 4, 2024
@jkotas jkotas merged commit 479defb into release/8.0-staging Apr 4, 2024
104 of 113 checks passed
@jkotas jkotas deleted the backport/pr-100190-to-release/8.0-staging branch April 17, 2024 01:26
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-NativeAOT-coreclr Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants