Refactor interop usage in DirectoryServices #51325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: The motivation for these changes is to remove cruft and provide a clearer picture of what dependencies libraries have. This is to support the work that is going on for dotnet/core#5651. |
eerhardt
reviewed
Apr 15, 2021
src/libraries/System.DirectoryServices/src/System/DirectoryServices/ExternDll.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Apr 16, 2021
| public static extern unsafe int ADsGetLastError(out int error, char* errorBuffer, int errorBufferLength, char* nameBuffer, int nameBufferLength); | ||
|
|
||
| [DllImport(ExternDll.Activeds, CharSet = CharSet.Unicode)] | ||
| [DllImport(global::Interop.Libraries.Activeds, CharSet = CharSet.Unicode)] |
There was a problem hiding this comment.
Why are all these global::s necessary? Is there some kind of naming conflict this is working around?
There was a problem hiding this comment.
Is there some kind of naming conflict this is working around?
Yes, there is an Interop namespace in this project.
There was a problem hiding this comment.
Ah, I see, the System.DirectoryServices.Interop namespace. Presumably once we clean up the rest of the interop we can remove the "global::".
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial implementation to more closely conform to the interop guidelines.
The goals here were the following:
[DllImport].