Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Http/2] Fix handling of effectively empty DATA frame #99502

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

ManickaP
Copy link
Member

Unblock a pending read only if we effectively read any data (after padding discard) or received EOS flag.

Fixes #99494

Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ManickaP ManickaP merged commit bbecf54 into dotnet:main Mar 11, 2024
109 of 111 checks passed
@ManickaP ManickaP deleted the http2-data branch March 11, 2024 08:24
@ManickaP
Copy link
Member Author

/backport to release/8.0-staging

Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/8250871969

@ManickaP
Copy link
Member Author

/backport to release/6.0-staging

Copy link
Contributor

Started backporting to release/6.0-staging: https://github.com/dotnet/runtime/actions/runs/8250876353

Copy link
Contributor

@ManickaP backporting to release/8.0-staging failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Fix handling effectively empty DATA frame
Using index info to reconstruct a base tree...
M	src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Connection.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Connection.cs
CONFLICT (content): Merge conflict in src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Connection.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix handling effectively empty DATA frame
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

Copy link
Contributor

@ManickaP an error occurred while backporting to release/8.0-staging, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

Copy link
Contributor

@ManickaP backporting to release/6.0-staging failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Fix handling effectively empty DATA frame
Using index info to reconstruct a base tree...
M	src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Connection.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Connection.cs
CONFLICT (content): Merge conflict in src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Connection.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix handling effectively empty DATA frame
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

Copy link
Contributor

@ManickaP an error occurred while backporting to release/6.0-staging, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

ManickaP added a commit to ManickaP/runtime that referenced this pull request Mar 13, 2024
* Fix handling effectively empty DATA frame

* Added test
ManickaP added a commit to ManickaP/runtime that referenced this pull request Mar 13, 2024
* Fix handling effectively empty DATA frame

* Added test
ManickaP added a commit that referenced this pull request Mar 26, 2024
… frame (#99502) (#99678)

* [Http/2] Fix handling of effectively empty DATA frame (#99502)

* Fix handling effectively empty DATA frame

* Added test

* Added missing method for the test
ManickaP added a commit that referenced this pull request Mar 26, 2024
* Fix handling effectively empty DATA frame

* Added test
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
@karelz karelz added this to the 9.0.0 milestone May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HTTP/2] Reading data assert
5 participants