[release/8.0] Fixing SignedXml.CheckSignature for enveloped signature with #xpointer(/) Reference
#99651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartonjs
added
Servicing-consider
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
bartonjs
changed the title
#xpointer(/) Reference#xpointer(/) Reference
…er(/)` Reference This additionally improves support for URI-less Reference elements. Co-authored-by: Kevin Jones <kevin@vcsjones.com>
bartonjs
force-pushed
the
xmldsig_backport
branch
from
16547ea
to
8b0fa56
Compare
vcsjones
approved these changes
Mar 13, 2024
|
Build Analysis says all failures are known. Servicing approval was granted over email. |
bartonjs
added
Servicing-approved
bartonjs
merged commit e373424
into
dotnet:release/8.0-staging
106 of 112 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95390. Backport of #95404 plus nuget package servicing authoring.
Description
SignedXml documents using an enveloped signature targeting the whole document with
<Reference URI="#xpointer(/)" />compute an invalid data hash during verification in the 7.0 and 8.0 versions of the SignedXml package.Customer Impact
Customers validating such a document produced by a different platform/library will be told the document's signature is not valid, when it is. Such documents produced with the 7.0 or 8.0 versions of the package will produce the correct signature, then fail signature verification.
Regression
Yes. It worked in .NET Framework, and in the nuget package up until 7.0-preview.3. It's broken in 7.0.x and 8.0.0.
Testing
A new test has been added.
Risk
Low. The existing tests cover alternative forms of referencing the root element, as well as referencing a non-root element.