Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix InputEventArgs.Timestamp field #7910

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Fix InputEventArgs.Timestamp field #7910

merged 1 commit into from
Jun 28, 2023

Conversation

hughbe
Copy link
Contributor

@hughbe hughbe commented Jun 9, 2023 •
edited by ghost
Loading

Fixes #7887

InputEventArgs.Timestamp field should not be static.

Microsoft Reviewers: Open in CodeFlow

@hughbe hughbe requested a review from a team as a code owner June 9, 2023 10:43
@ghost ghost assigned hughbe Jun 9, 2023
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jun 9, 2023
@ghost ghost requested review from dipeshmsft and singhashish-wpf June 9, 2023 10:43
@ghost ghost added the Community Contribution A label for all community Contributions label Jun 9, 2023
lindexi
lindexi approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@lindexi lindexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@miloush
Copy link
Contributor

miloush commented Jun 11, 2023

I would think it is a good practice to keep the changes to minimum. This could be a PR of one word deleted, but it is full of changes unrelated to the issue. It renames private fields which was not discussed. Not sure why comments need to be deleted.

@pchaurasia14
Copy link
Member

@hughbe - Could you please address the review comments mentioned by @miloush.

We intend to include this change in our upcoming test pass.

@hughbe
Copy link
Contributor Author

hughbe commented Jun 19, 2023

Have updated this PR, apologies for the delay

@dipeshmsft dipeshmsft merged commit 304e6fb into dotnet:main Jun 28, 2023
8 checks passed
@dipeshmsft
Copy link
Member

@hughbe thanks for bringing the issue and for providing the fix as well. Thanks for your continued support to WPF.

@hughbe hughbe deleted the inputeventargs-fix branch June 28, 2023 10:02
@ghost ghost locked as resolved and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lindexi lindexi lindexi approved these changes

@pchaurasia14 pchaurasia14 pchaurasia14 approved these changes

@dipeshmsft dipeshmsft Awaiting requested review from dipeshmsft

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

Assignees

@hughbe hughbe

Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InputEventArgs.Timestamp field is static and shared by all instances
5 participants
@hughbe @miloush @pchaurasia14 @dipeshmsft @lindexi