Add validation to active_gate_url and api_token (#34)

lib/fluent/plugin/dynatrace_constants.rb

@@ -20,7 +20,7 @@ module Plugin
     class DynatraceOutputConstants
       # The version of the Dynatrace output plugin
       def self.version
-        '0.1.6'
+        '0.2.0'
       end
     end
   end

lib/fluent/plugin/out_dynatrace.rb

@@ -64,7 +64,10 @@ def configure(conf)
         compat_parameters_convert(conf, :inject)
         super
 
-        @uri = URI.parse(@active_gate_url)
+        raise Fluent::ConfigError, 'api_token is empty' if @api_token.empty?
+
+        @uri = parse_and_validate_uri(@active_gate_url)
+
         @agent = Net::HTTP.new(@uri.host, @uri.port)
 
         return unless uri.scheme == 'https'
@@ -173,6 +176,22 @@ def failure_message(res)
 
         "failed to request #{uri} (#{res_summary})"
       end
+
+      #############################################
+
+      private
+
+      def parse_and_validate_uri(uri_string)
+        raise Fluent::ConfigError, 'active_gate_url is empty' if uri_string.empty?
+
+        uri = URI.parse(uri_string)
+        raise Fluent::ConfigError, 'active_gate_url scheme must be http or https' unless
+          %w[http https].include?(uri.scheme)
+
+        raise Fluent::ConfigError, 'active_gate_url must include an authority' if uri.host.nil?
+
+        uri
+      end
     end
   end
 end

test/plugin/out_dynatrace_test.rb

@@ -145,6 +145,70 @@ def create_driver(conf = config)
       assert_equal true, d.instance.agent.original_agent.use_ssl?
       assert_equal OpenSSL::SSL::VERIFY_NONE, d.instance.agent.original_agent.verify_mode
     end
+
+    test 'should throw if active_gate_url is not set' do
+      assert_raises Fluent::ConfigError do
+        create_driver(%(
+        active_gate_url
+        api_token       secret
+      ))
+      end
+    end
+
+    test 'with IPv6 as host should not throw' do
+      d = create_driver(%(
+        active_gate_url http://[::1]//logs
+        api_token       secret
+      ))
+      assert_equal 'http://[::1]//logs', d.instance.active_gate_url
+      assert_equal 'secret', d.instance.api_token
+    end
+
+    test 'should throw if active_gate_url scheme is not http or https' do
+      assert_raises Fluent::ConfigError do
+        create_driver(%(
+        active_gate_url ./relative/path
+        api_token       secret
+      ))
+      end
+
+      assert_raises Fluent::ConfigError do
+        create_driver(%(
+        active_gate_url example.dynatrace.com/logs
+        api_token       secret
+      ))
+      end
+
+      assert_raises Fluent::ConfigError do
+        create_driver(%(
+        active_gate_url example
+        api_token       secret
+      ))
+      end
+
+      assert_raises Fluent::ConfigError do
+        create_driver(%(
+        active_gate_url ssh://example.dynatrace.com/logs
+        api_token       secret
+      ))
+      end
+
+      assert_raises Fluent::ConfigError do
+        create_driver(%(
+        active_gate_url http:path/to/logs
+        api_token       secret
+      ))
+      end
+    end
+
+    test 'should throw if api_token is not set' do
+      assert_raises Fluent::ConfigError do
+        create_driver(%(
+        active_gate_url https://example.dynatrace.com/logs
+        api_token
+      ))
+      end
+    end
   end
 
   sub_test_case 'tests for #write' do