feat(select): Removing unneeded aria-label - FRONT-4477 (#3458)

ec-europa · Jul 2, 2024 · 2418fd1 · 2418fd1 · github-actions · Jul 2, 2024
1 parent 9969ae5
commit 2418fd1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/src/implementations/twig/components/form-group/__snapshots__/form-group.test.js.snap b/src/implementations/twig/components/form-group/__snapshots__/form-group.test.js.snap
@@ -4352,7 +4352,6 @@ exports[`Form group  with Select renders correctly 1`] = `
     >
       <select
         aria-describedby="select-default-helper"
-        aria-label="country"
         class="ecl-select"
         data-ecl-auto-init="Select"
         id="select-default"
@@ -4495,7 +4494,6 @@ exports[`Form group  with Select renders correctly when disabled 1`] = `
     >
       <select
         aria-describedby="select-default-helper"
-        aria-label="country"
         class="ecl-select"
         data-ecl-auto-init="Select"
         disabled=""
@@ -4641,7 +4639,6 @@ exports[`Form group  with Select renders correctly when invalid 1`] = `
       <select
         aria-describedby="select-default-helper select-default-invalid"
         aria-invalid="true"
-        aria-label="country"
         class="ecl-select"
         data-ecl-auto-init="Select"
         id="select-default"
@@ -4803,7 +4800,6 @@ exports[`Form group  with Select renders correctly when required 1`] = `
     >
       <select
         aria-describedby="select-default-helper"
-        aria-label="country"
         class="ecl-select"
         data-ecl-auto-init="Select"
         id="select-default"
@@ -4948,7 +4944,6 @@ exports[`Form group  with Select renders correctly with extra attributes 1`] = `
     >
       <select
         aria-describedby="select-default-helper"
-        aria-label="country"
         class="ecl-select"
         data-ecl-auto-init="Select"
         id="select-default"
@@ -5091,7 +5086,6 @@ exports[`Form group  with Select renders correctly with extra class names 1`] =
     >
       <select
         aria-describedby="select-default-helper"
-        aria-label="country"
         class="ecl-select"
         data-ecl-auto-init="Select"
         id="select-default"

diff --git a/src/implementations/twig/components/select/select.html.twig b/src/implementations/twig/components/select/select.html.twig
@@ -114,7 +114,6 @@
   {% endif %}
   {% if _name is not empty %}
     name="{{ _name }}"
-    aria-label="{{ _name }}"
   {% endif %}
   {% if _required %}
     required

diff --git a/src/implementations/twig/components/select/select.test.js b/src/implementations/twig/components/select/select.test.js
@@ -8,8 +8,14 @@ import { axe, toHaveNoViolations } from 'jest-axe';
 import specSingle from '@ecl/specs-component-select/demo/data-single';
 import specMultiple from '@ecl/specs-component-select/demo/data-multiple';
 
-const dataSingle = specSingle.input;
-const dataMultiple = specMultiple.input;
+const dataSingle = {
+  ...specSingle.input,
+  extra_attributes: [{ name: 'aria-label', value: 'country' }],
+};
+const dataMultiple = {
+  ...specMultiple.input,
+  extra_attributes: [{ name: 'aria-label', value: 'country' }],
+};
 
 expect.extend(toHaveNoViolations);