refactor(buttons): refactor buttons’ markup and styling - INNO-307 #141
Conversation
# Conflicts: # framework/components/ecl-button-groups/_button-groups.scss # framework/components/ecl-buttons/_buttons.scss
| Style | ||
| See Default button style | ||
|
|
||
| # Guidance |
There was a problem hiding this comment.
A bit painful to see that we already know it's unfinished work and someone will have to update urgently at worst moment
| @@ -69,6 +67,10 @@ a.breadcrumb__link { | |||
| // the breadcrumb segment width. | |||
| width: 11px; | |||
| color: #fff; | |||
|
|
|||
| &::before { | |||
There was a problem hiding this comment.
Is as visible now, the arrow will have to be adjusted a bit.
There was a problem hiding this comment.
Will see when working on breadcrumbs 👼
| Buttons | ||
| /** | ||
| * Buttons component | ||
| * @define button |
There was a problem hiding this comment.
Isn't this @define ecl-button?
There was a problem hiding this comment.
Nope, the prefix should not be added in the definition :)
| {% endif %} | ||
|
|
||
| {% if icon is defined %} | ||
| {% set extraClass = extraClass ~ ' ecl-button--' ~ icon %} |
There was a problem hiding this comment.
Adding a comment on this one will be appreciated, it currently seems a bit magical and takes time to understand.
There was a problem hiding this comment.
It definitely needs more documentation
| @@ -1,354 +1,161 @@ | |||
| /* | |||
| Buttons | |||
There was a problem hiding this comment.
Pointer cursor missing on hover, not sure if this is desired behavior.
There was a problem hiding this comment.
W3C: "pointer" The cursor is a pointer that indicates a link.
Closes #86.
Basically, I've imported @emeryro's work and rewritten the template (one template to rule them all). I still need to work on the "variants" (fractal-ly speaking), to provide more concrete examples.
TODO: