feat(text-input): provide ecl-text-input class - INNO-520 #150
Conversation
…opa/europa-component-library into feat/input-texts-INNO-520
|
|
||
| Markup: html/form-group.html |
There was a problem hiding this comment.
The ecl-forms-form-groups.twig still has old classes.
| @@ -1,5 +1,5 @@ | |||
| module.exports = { | |||
| title: 'Text inputs', | |||
| label: 'Text inputs', | |||
| status: 'planned', | |||
| status: 'ready', | |||
There was a problem hiding this comment.
The help-block part is still in progress though.
| <label for="example-input-id-1">Text Input - default with placeholder</label> | ||
| <p class="help-block">This is some help text.</p> | ||
| <input type="text" class="form-control" id="example-input-id-1" placeholder="Some placeholder text."/> | ||
| <input type="text" class="ecl-text-input" id="example-input-id-1" placeholder="Some placeholder text."/> |
There was a problem hiding this comment.
If possible, please order the ids and names.
Also, it seems that some examples are missing: https://ec-europa.github.io/ec-europa-theme/section-form.html#kssref-form-text-input
There was a problem hiding this comment.
No missing examples actually: they made an example for the :focus state by adding a class for that... Do we want to follow this road?
| @@ -1,8 +1,20 @@ | |||
| { | |||
| "private": true, | |||
| "name": "@ec-europa/ecl-forms-text-inputs", | |||
There was a problem hiding this comment.
Either please add "@ec-europa/ecl-forms-help-blocks" as a dependency or maybe just remove it for the time being.
There was a problem hiding this comment.
I'll add it as a peerDependency, thanks
There was a problem hiding this comment.
Should be better now
|
Ready for a last review :) |
Reference: https://ec-europa.github.io/ec-europa-theme/section-form.html#kssref-form-text-input
TODO: