refactor(page-header): update page header according to DT spec - INNO-441 #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I couldn't complete the full set of changes, though it seems few things are missing such as highlights with text, background images
|
|
||
| .page-header { | ||
| margin: 0; | ||
| padding: 0 0 1.5em; |
There was a problem hiding this comment.
Any specific reason why removing this?
There was a problem hiding this comment.
I didn't have any reason to keep it, as it didn't change the display
|
@kalinchernev I based my implementation on DT specifications (on their wiki), not on DTT implementation (even if I sticked to the design). |
|
Missing modifiers have been added. |
kalinchernev
force-pushed
the
refactor/page-header-INNO-441
branch
from
2eca4cc
to
d3ebd01
Compare
degliwe
suggested changes
May 31, 2017
kalinchernev
force-pushed
the
refactor/page-header-INNO-441
branch
from
d3ebd01
to
072cf7e
Compare
kalinchernev
approved these changes
May 31, 2017
…-europa/europa-component-library into refactor/page-header-INNO-441 # Conflicts: # framework/components/ecl-page-headers/_page-headers.scss # framework/components/ecl-page-headers/corporate/corporate.twig # framework/components/ecl-page-headers/improved-basic/improved-basic.twig # framework/components/ecl-page-headers/improved-complete/improved-complete.twig
|
Paddings have been fixed. |
degliwe
suggested changes
May 31, 2017
|
improve-complete has been fixed |
degliwe
approved these changes
May 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page header updated.
Code cleaned up. There were lots of unused code, maybe there are some other use cases, but I didn't found them in DT documentation.
Breadcrumb and meta components will have to be updated later (I kept them as is for now)