-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(buttons): make proper use of composition - INNO-590 #172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The syntax is clear enough for me.
I think this commit is a good example of making configurable component, like having a small API for the component. For making it more accessible for developers implementing the API, probably a small documentation on how to use it would be useful, in the page of the component itself.
For demonstrating a composition, I think we need also an example where "children" components are expected and parsed regardless of what one puts for children.
Hmmm, indeed it makes sense in some cases to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working ok
Does the syntax of
ecl-buttons.twig
seem clear enough?