Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reset): fix box-sizing and remove other rules - INNO-416 #202

Merged
merged 5 commits into from
Jun 20, 2017
Merged

fix(reset): fix box-sizing and remove other rules - INNO-416 #202

merged 5 commits into from
Jun 20, 2017

Conversation

yhuard
Copy link
Contributor

@yhuard yhuard commented Jun 20, 2017

Some rules will be moved to the next "website" preset we will provide

@yhuard yhuard requested a review from emeryro June 20, 2017 09:36
@yhuard
Copy link
Contributor Author

yhuard commented Jun 20, 2017

Currently, the following components break:

  • breadcrumbs
  • footers --default and --custom
  • navigation-menus

@yhuard
Copy link
Contributor Author

yhuard commented Jun 20, 2017

Breadcrumb is now better in fact. Checking the other components...

@yhuard
Copy link
Contributor Author

yhuard commented Jun 20, 2017

All look fine, I'll update the screenshots

@emeryro emeryro self-assigned this Jun 20, 2017
emeryro
emeryro requested changes Jun 20, 2017
View reviewed changes
Copy link
Contributor

@emeryro emeryro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pagers are kind of broken now (see screenshots)

emeryro
emeryro approved these changes Jun 20, 2017
View reviewed changes
Copy link
Contributor

@emeryro emeryro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review ok.

@yhuard yhuard merged commit 960cef3 into master Jun 20, 2017
@yhuard yhuard deleted the refactor/reset branch June 20, 2017 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emeryro emeryro emeryro approved these changes

Assignees

@emeryro emeryro

Labels
tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhuard @emeryro