-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(select): upgrade component - INNO-589 #205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it's okay. Just need to set border-radius: 0
and write tests
background-color: #fff; | ||
background-image: none; | ||
border: 1px solid $ecl-color-shade; | ||
color: $ecl-color-shade; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a border-radius: 0
around here :)
screenshots and border-radius have been added |
Select input upgrade.
CSS is very similar to the one used for text input