feat(legends): legends INNO-630 #206
Conversation
degliwe
commented
Jun 21, 2017
degliwe
commented
- upgrade component
- test
- add documentation
|
Your pull request doesn't follow our guidelines. Please fix the following:
Click here for details. Thank you! 🙏 |
|
Thank you, the title and description now looks good! |
degliwe
added
tag: documentation
tag: enhancement
and removed
tag: documentation
labels
| @@ -1 +1,4 @@ | |||
| # Legends | |||
There was a problem hiding this comment.
In other components we kept the global title, so I assume we should keep it here too (and set the other title as second level title)
There was a problem hiding this comment.
There was a problem hiding this comment.
Well let's say like every other component, except button :)
We will have to synchronize here
| */ | ||
|
|
||
| $form-item-legend-font-size: map-get($ecl-font-size, 'xs'); | ||
|
|
||
| .legend { | ||
| .ecl-form-legend { |
There was a problem hiding this comment.
not sure that we have to name class "ecl-form-legend", and not only "ecl-legend". For instance we name other component's classes "ecl-text-input" or "ecl-select"
There was a problem hiding this comment.
Ex: we have 2 labels components (ecl-label and ecl-form-label) this legend is specific for form element so it seems more future proof and descriptive to stick to ecl-form-legend.
There was a problem hiding this comment.
To be discussed with the team, as we will have this issue again in the future
| <legend class="ecl-form-legend">Legend text comes here</legend> |
There was a problem hiding this comment.
We should put the content into a variable, so we could use composition.
