Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(footers): use context data - INNO-644 #212

Merged
merged 7 commits into from
Jun 26, 2017
Merged

Conversation

kalinchernev
Copy link
Contributor

Short summary:

  • renames scss files as agreed recently
  • adds zero margin for the same reason
  • adds context data
  • logic does not need variant any more, because of the type property
  • updated tests

Notes:

  • a11y tests fail with errors I can understand:
    expected { Object (stackTrace, message) } to be null
  • the logic for showing menu titles might seem complex, but I think it's not if one follows the custom menu which contains almost all scenarios. Might need more documentation to say that presence or not of certain properties yield various types of menus and their titles

@yhuard yhuard self-assigned this Jun 26, 2017
@yhuard
Copy link
Contributor

yhuard commented Jun 26, 2017

@kalinchernev Your a11y tests failed because the selector you were targeting did not exist, that's it

@yhuard yhuard merged commit 2f11590 into master Jun 26, 2017
@yhuard yhuard deleted the fix/footers-INNO-644 branch June 26, 2017 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants