Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(page-header): use breadcrumb and add tests - INNO-647 #215

Merged
merged 1 commit into from
Jun 26, 2017

Conversation

degliwe
Copy link
Contributor

@degliwe degliwe commented Jun 26, 2017

  • use breadcrumb (composition)
  • add basic visual regression tests
  • force handle to allow navigation

@ghost
Copy link

ghost commented Jun 26, 2017

Your pull request doesn't follow our guidelines. Please fix the following:

  • Pull request title must end with a JIRA issue reference (?)

Click here for details.

Thank you! 🙏

This comment was made by GitMagic – Magically enforcing your contribution guidelines.

@yhuard yhuard changed the title fix(page-header): use breadcrumb and add tests -INNO647 fix(page-header): use breadcrumb and add tests - INNO-647 Jun 26, 2017
@ghost
Copy link

ghost commented Jun 26, 2017

Thank you, the title and description now looks good! :bowtie:

Copy link
Contributor

@yhuard yhuard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@degliwe degliwe merged commit a6c5c42 into master Jun 26, 2017
@degliwe degliwe deleted the fix/page-header-INNO-647 branch June 26, 2017 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants