Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(file-upload): Add dynamic upload file list example - FRONT-3525 #2328

Merged
merged 19 commits into from
Mar 7, 2022

Conversation

@github-actions
Copy link

github-actions bot commented Feb 2, 2022

Copy link
Contributor

@emeryro emeryro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a tricky task here...
On one side, putting the html in the story helps keeping the template clean, on the other side we still add some specific css which will not be used in most cases. So we are kind of in-between two positions here.

I would say that if we provide the css, we could also provide the structured html coming with it (so for instance having already the "ecl-file-upload__item-action" section, even if empty)
Or we don't provide the css either (relying on utilities)

@papegaill
Copy link
Contributor Author

that's a tricky task here... On one side, putting the html in the story helps keeping the template clean, on the other side we still add some specific css which will not be used in most cases. So we are kind of in-between two positions here.

I would say that if we provide the css, we could also provide the structured html coming with it (so for instance having already the "ecl-file-upload__item-action" section, even if empty) Or we don't provide the css either (relying on utilities)

Many thanks for the review @emeryro !
You are totally right, I reviewed the markup using only utilities classes and I removed the extra css 👍

emeryro
emeryro previously approved these changes Feb 9, 2022
Copy link
Contributor

@emeryro emeryro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the version number to update and that's fine

@emeryro emeryro merged commit 8bbdca3 into v3-dev Mar 7, 2022
@emeryro emeryro deleted the feat/FRONT-3525 branch March 7, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants