-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(file-upload): Add dynamic upload file list example - FRONT-3525 #2328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's a tricky task here...
On one side, putting the html in the story helps keeping the template clean, on the other side we still add some specific css which will not be used in most cases. So we are kind of in-between two positions here.
I would say that if we provide the css, we could also provide the structured html coming with it (so for instance having already the "ecl-file-upload__item-action" section, even if empty)
Or we don't provide the css either (relying on utilities)
Many thanks for the review @emeryro ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just the version number to update and that's fine
Composition previews: