fix(accessibility): Pagination, carousel, gallery and news-ticker - FRONT-3591 #2375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emeryro
changed the title
emeryro
reviewed
Apr 5, 2022
src/implementations/twig/components/news-ticker/news-ticker.html.twig
Outdated
Show resolved
Hide resolved
src/implementations/twig/components/news-ticker/news-ticker.html.twig
Outdated
Show resolved
Hide resolved
papegaill
added
process: review needed
process: business approval needed
and removed
Question
labels
emeryro
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix accessibility issues for the following EC & EU components:
Pagination
https://ec.europa.eu/component-library/playground/ec/?path=/story/components-navigation-pagination--default
Carousel
https://ec.europa.eu/component-library/playground/ec/?path=/story/components-carousel--default
Media container
https://ec.europa.eu/component-library/playground/ec/?path=/story/components-media-container--embedded-video
News Ticker
https://ec.europa.eu/component-library/playground/ec/?path=/story/components-news-ticker--default
Button
hide_labelparameter added for screen reader only