feat(ext-links): Adding external icon to links based on a parameter - FRONT-3601 #2384
Conversation
| @@ -12,6 +12,8 @@ module.exports = { | |||
| label: 'Better regulation', | |||
| path: exampleLink, | |||
| level: 1, | |||
| external: true, | |||
There was a problem hiding this comment.
for the demo to COMM we can have the external link by default, but I guess that on the end we should have the normal link here (and maybe a control to have it external)
| @@ -16,6 +16,8 @@ module.exports = { | |||
| type: 'standalone', | |||
| label: 'Title', | |||
| path: exampleLink, | |||
| icon_path: 'icons.svg', | |||
| external: true, | |||
There was a problem hiding this comment.
same remark for the default external link
| { label: 'Item 4.13', path: exampleLink }, | ||
| { label: 'Item 4.14', path: exampleLink }, | ||
| ], | ||
| external: true, |
There was a problem hiding this comment.
we should update the translated data file too
emeryro
added
process: changes requested
process: business approval needed
and removed
process: under review
labels
|
Thanks Romain for reviewing this, the examples were meant to show where the "functionality" was added to give a chance both to comm and platform to see what the result would have been. I agree that if this gets "validated" by our stakeholders we can simply remove the icon in some of the stories where we are currently showing it, i would also keep the control to activate it only for the link stories. |
|
It still not entirely clear how are we going to release this, the pr has been kept against v3, the examples have been removed, the link is the main "entry" point to test the "external icon" using the associated control |
|
The external icon has been added also to the tag component, only when the tag is of type "link" |
The approach used is to give priority to the external icon:
it means that if the link is set to be external it will take precedence on any other "icon" that might have been passed to the component.
This can be tested by setting an icon through the controls, if the link is external nothing should change.