feat(cards): refactor cards with content block - FRONT-3606 #2469
Conversation
| @@ -193,9 +207,23 @@ export default { | |||
| decorators: [withCode, withNotes], | |||
| }; | |||
|
|
|||
| export const Card = (args) => card(prepareData(dataCard, args)); | |||
| export const Default = (args) => card(prepareData(dataCardDefault, args)); | |||
|
|
|||
There was a problem hiding this comment.
At this point i wonder about the reason why having multiple stories in card. I find that confusing considering that all the optional content of a card has toggles to show/hide them, i think that one single story "default" would be enough, but you probably based also on requests by comm, so just a personal thought..
There was a problem hiding this comment.
I won't say that this is a "request", but all their design mention 3 examples of cards (default, tags, list), so I guess that having them with the same naming would avoid some discussions
There was a problem hiding this comment.
It seems all good to me, i do have a concern regarding the markup, though, but it is coming from the content block, we have now these very long class names ex: ecl-content-block__secondary-meta-container and this code is going to be everywhere making the source code "heavier" although semantically correct.
|
wouldn't it be good to have a test also with the "old" data to check the backward compatibility of this implementation..? |
Update card component, to rely on the new content block element
Important:
Data structure has been updated/simplified (), but a temporary backward compatibility has been provided to avoid breaking changes.
Main modifications in data: