Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(expandables): update doc - INNO-657 #252

Merged
merged 5 commits into from
Jul 10, 2017
Merged

feat(expandables): update doc - INNO-657 #252

merged 5 commits into from
Jul 10, 2017

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented Jul 10, 2017

Update doc

@yhuard yhuard self-assigned this Jul 10, 2017
yhuard
yhuard reviewed Jul 10, 2017
View reviewed changes
Copy link
Contributor

@yhuard yhuard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove all the whitespaces?

@kalinchernev kalinchernev requested a review from a team July 10, 2017 11:20
kalinchernev
kalinchernev approved these changes Jul 10, 2017
View reviewed changes
Copy link
Contributor

@kalinchernev kalinchernev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wiki does not have spacing as here.

@kalinchernev kalinchernev self-assigned this Jul 10, 2017
@emeryro
Copy link
Contributor Author

emeryro commented Jul 10, 2017

Well, no particular reason, I just kept it coherant with what had been done on another readme file.
If that really bother you, we can put they back, but visually there is no difference.

@kalinchernev kalinchernev merged commit 23897de into master Jul 10, 2017
@kalinchernev kalinchernev deleted the feat/doc-expandables-INNO-657 branch July 10, 2017 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhuard yhuard yhuard left review comments

@kalinchernev kalinchernev kalinchernev approved these changes

Assignees

@kalinchernev kalinchernev

@yhuard yhuard

Labels
tag: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emeryro @kalinchernev @yhuard