feat(menu): Revamp navigation and styles - FRONT-3697 #2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papegaill
changed the title
papegaill
changed the title
papegaill
added
process: review needed
process: business approval needed
and removed
process: WIP
labels
…brary into feat/FRONT-3697
… + small tweaks - FRONT-3697
…brary into feat/FRONT-3697
planctus
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previews:
Specs:
@emeryro General remark on the delay of transitions for the hover states, it slows down the desktop experience.
Also in FF the color of the labels doesn't follow the delay correctly, so we have a flick, this is already the case on the current menu. I tried removing the delay
ecl-menu--transitionand I don't see any particular issue with the menu. Not knowing exactly the original reason for it (surely performance), I left it for now. But if you think we can remove it, then it would be much better to delete it.