Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete CODEOWNERS - no issue #276

Merged
merged 1 commit into from
Jul 12, 2017
Merged

chore: delete CODEOWNERS - no issue #276

merged 1 commit into from
Jul 12, 2017

Conversation

yhuard
Copy link
Contributor

@yhuard yhuard commented Jul 12, 2017

PR description

Please drop a few lines about the PR: what it does, how to test it, etc.

QA Checklist

In order to ensure a safe and quick review, please check that your PR follow those guidelines:

  • package.json is up-to-date and @ec-europa/ecl-base is part of the dependencies
  • I have given the fractal status “ready” to my component
  • I have declared @define mycomponent in the SCSS file
  • I have specified margin: 0; on the CSS component
  • I have provided tests
  • I follow the naming guidelines
  • the component supports composition
  • the template is fully functional
  • I have filled the README.md file (at least a few lines)
  • I have checked the dependencies
  • there are no hardcoded strings (all content come from the context)

@yhuard yhuard requested a review from a team July 12, 2017 12:08
@ghost
Copy link

ghost commented Jul 12, 2017

Your pull request doesn't follow our guidelines. Please fix the following:

  • Pull request title must end with a JIRA issue reference (?)
  • Pull request title must have one of the following prefixes: "feat(*): ", "fix(*): ", "docs(*): ", "style(*): ", "refactor(*): ", "perf(*): ", "test(*): ", "chore(*): " (?)
  • Pull request title must start with lowercase (?)

Click here for details.

Thank you! 🙏

This comment was made by GitMagic – Magically enforcing your contribution guidelines.

@yhuard yhuard changed the title Delete CODEOWNERS chore: delete CODEOWNERS - no issue Jul 12, 2017
@ghost
Copy link

ghost commented Jul 12, 2017

This pull request still violates some of our guidelines:

  • Pull request title must have one of the following prefixes: "feat(*): ", "fix(*): ", "docs(*): ", "style(*): ", "refactor(*): ", "perf(*): ", "test(*): ", "chore(*): " (?)

Click here for details.

@yhuard yhuard merged commit 558f43e into master Jul 12, 2017
@yhuard yhuard deleted the yhuard-patch-1 branch July 12, 2017 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant