Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(travis): remove aws artifacts upload - no issue #277

Merged
merged 1 commit into from
Jul 12, 2017
Merged

chore(travis): remove aws artifacts upload - no issue #277

merged 1 commit into from
Jul 12, 2017

Conversation

yhuard
Copy link
Contributor

@yhuard yhuard commented Jul 12, 2017

Those artifacts were not used.

@yhuard yhuard requested a review from kalinchernev July 12, 2017 13:11
@kalinchernev kalinchernev self-assigned this Jul 12, 2017
kalinchernev
kalinchernev suggested changes Jul 12, 2017
View reviewed changes
Copy link
Contributor

@kalinchernev kalinchernev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good!
How about splitting const updatedPackages = collector.collectUpdatedPackages(); check in a package out of the wdio and run the wdio only if there are updates?

@yhuard yhuard merged commit 305f1f2 into master Jul 12, 2017
@yhuard yhuard deleted the chore/travis branch July 12, 2017 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalinchernev kalinchernev kalinchernev approved these changes

Assignees

@kalinchernev kalinchernev

Labels
tag: internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhuard @kalinchernev