Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): upgrades - noissue #287

Merged
merged 2 commits into from
Jul 17, 2017
Merged

Conversation

kalinchernev
Copy link
Contributor

PR description

Please drop a few lines about the PR: what it does, how to test it, etc.

QA Checklist

In order to ensure a safe and quick review, please check that your PR follow those guidelines:

  • package.json is up-to-date and @ec-europa/ecl-base is part of the dependencies
  • I have given the fractal status “ready” to my component
  • I have declared @define mycomponent in the SCSS file
  • I have specified margin: 0; on the CSS component
  • I have provided tests
  • I follow the naming guidelines
  • the component supports composition
  • the template is fully functional
  • I have filled the README.md file (at least a few lines)
  • I have checked the dependencies
  • there are no hardcoded strings (all content come from the context)

@kalinchernev kalinchernev requested a review from a team July 17, 2017 09:05
@kalinchernev kalinchernev changed the title chore(dependencies): upgrades chore(dependencies): upgrades - noissue Jul 17, 2017
@yhuard yhuard merged commit f23031d into master Jul 17, 2017
@yhuard yhuard deleted the chore/update-dependencies branch July 17, 2017 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants